Re: [PATCH v2 1/2] CI: limit GitHub Actions to designated branches

From: Jeff King <peff@peff.net>
Date: May 5, 2020, 16:43 UTC
Message-ID: <20200505164326.GA64077@coredump.intra.peff.net>
In-Reply-To: <20200505002055.GC64230@syl.local>

On Mon, May 04, 2020 at 06:20:55PM -0600, Taylor Blau wrote:

Show 13 quoted lines

> > > Of course, I don't want to maintain a one-patch difference between
> > > ttaylorr/git@master and git/git@master, so I wonder if we could get a
> > > little more creative with these rules and actually run Actions on
> > > *every* branch, but introduce a new first step which stops the rest of
> > > the actions run (so that in practice we're not running CI on
> > > non-integration branches in Junio's tree).
> >
> > I don't understand what that would accomplish. If we ran the actions on
> > every branch but stopped the run, then you wouldn't get the CI results
> > you want. What am I missing?
> 
> That on forks of git/git we *would't* stop the run for non-integration
> branches, i.e., that we'd have something like:

Ah, so the first step is "if we are gitster/git, then do not run", not "do not run".

But that is missing the point of the exercise, no? The question of what gitster/git should do was a side conversation. The purpose of Dscho's original patch and Danh's followup was to allow anybody to choose which branches in their own fork. I.e.:

>   * Actions is running on all branches, of all forks, all the time.

This is how it works now, and is the exact thing we are trying to fix.

-Peff