Re: [PATCH v2 1/2] CI: limit GitHub Actions to designated branches
- From
Jeff King <peff@peff.net>
- Date
- May 4, 2020, 16:23 UTC
- Message-ID
- <20200504162311.GE12842@coredump.intra.peff.net>
- In-Reply-To
- <73de97dfebfccabe9f1bf32ea41aea5008a949cd.1588607262.git.congdanhqx@gmail.com>
On Mon, May 04, 2020 at 10:49:31PM +0700, Đoàn Trần Công Danh wrote:
Show 12 quoted lines
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml > index fd4df939b5..ea43b03092 100644 > --- a/.github/workflows/main.yml > +++ b/.github/workflows/main.yml > @@ -1,6 +1,18 @@ > name: CI/PR > > -on: [push, pull_request] > +on: > + pull_request: > + branches: > + - '**'
Doing "**" here makes sense to catch everything (it would be even better if we could just say "everything with a pull request" by omitting the branch filter entirely, but maybe that's not possible).
> + tags: > + - '*'
Would we want that here, too? I guess nobody is likely to push "foo/v1.2.3".
Or on the flip side, would we want to tighten this? If I push a tag "wip", I probably don't want it built. Probably the right rule is "annotated tags only", but I suspect that's not possible.
Show 7 quoted lines
> + push: > + branches: > + - maint > + - master > + - next > + - jch > + - pu
What happened to "for-ci" (presumably "for-ci/**")?
-Peff