Re: [PATCH v8 10/10] ce_compare_data() did not respect conversion
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 29, 2016, 21:09 UTC
- Message-ID
- <xmqqvb30w29z.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1461942126-16296-1-git-send-email-tboegi@web.de>
tboegi@web.de writes:
Show 16 quoted lines
> From: Torsten Bögershausen <tboegi@web.de> > > We define the working tree file is clean if either: > > * the result of running convert_to_git() on the working tree > contents matches what is in the index (because that would mean > doing another "git add" on the path is a no-op); OR > > * the result of running convert_to_working_tree() on the content > in the index matches what is in the working tree (because that > would mean doing another "git checkout -f" on the path is a > no-op). > > Add an extra check in ce_compare_data() in read_cache.c. > > Helped-by: Junio C Hamano <gitster@pobox.com>
Well, didn't I do exactly the above much earlier and discarded it because that breaks the definition of "diff"? Or is this doing something differently?