Re: [PATCH v1 1/7] Make it possible to get sha1 for a path from the index

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 29, 2016, 13:28 UTC
Message-ID: <CACsJy8A-nwv2B=6B4TqAz+i=DxC6Wu5yO924uaXWd5zLuXFRTQ@mail.gmail.com>
In-Reply-To: <1459257930-17193-1-git-send-email-tboegi@web.de>

On Tue, Mar 29, 2016 at 8:25 PM,  <tboegi@web.de> wrote:

> From: Torsten Bögershausen <tboegi@web.de>
>
> Factor out the retrival of the sha1 for a given path in
> read_blob_data_from_index() into the function get_sha1_from_index().

Getting _sha1_ from index is one function call and a memory dereference or two. I think you mean get sha1 _file_ (or data) from index. Maybe put either word in the function name.

> This will be used in the next commit, when convert.c can do the analyze
> for "text=auto" without slurping the whole blob into memory at once.

-- 
Duy

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.