Re: [PATCH v8 10/10] ce_compare_data() did not respect conversion

From: Junio C Hamano <gitster@pobox.com>
Date: May 6, 2016, 17:11 UTC
Message-ID: <xmqq4mab5cwy.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <e33e0b87-caa1-84a3-7c5c-8938e0c78a77@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

> We only need to pay extra attention when there is an external
> clean/smudge filter defined - otherwise we should be able to skip
> it - after 10/10.

The last two words worries me. The goal of the suggested fix was to make sure that

	$ git reset --hard && git diff

reports that there _are_ differences in the working tree files, if the to-git and to-working-tree conversion do not round-trip. It is a total opposite of 10/10, which hides the fact that working tree contents, if added to the index, would change the index.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.