Re: [PATCH v1 6/7] correct blame for files commited with CRLF

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 29, 2016, 20:32 UTC
Message-ID: <xmqqa8lhvxd4.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqio05vxo9.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 10 quoted lines

> Torsten Bögershausen <tboegi@web.de> writes:
>
>> If we had made the CRLF -> LF conversion, yes. But we don't do that.
>> crlf_to_git() returns without touching the line endings.
>
> That sounds quite broken.  How would a user ever fix broken data in
> the index then?  I know the commit that often appears in these
> discussions claims to give us "safer CRLF" handling, but I have a
> suspicion that perhaps we should rethink if that claim is really
> true.  Isn't it giving us more problems than it is worth?

Having said all that, within the context of the current codebase where autocrlf refuses to do the conversion, I agree that teaching blame to follow the same logic makes sense. Let me review the series up to 6/7 with fresh eyes.

Thanks.