Re: [PATCH v1 1/7] Make it possible to get sha1 for a path from the index
- From
Torsten Bögershausen <tboegi@web.de>
- Date
- Mar 29, 2016, 15:05 UTC
- Message-ID
- <56FA99AF.1040006@web.de>
- In-Reply-To
- <CACsJy8DqN+s2inEeO++hcen1MH+9Op_DFG2x6n8D4xuVfgAu8w@mail.gmail.com>
On 2016-03-29 15.31, Duy Nguyen wrote:
Show 15 quoted lines
> On Tue, Mar 29, 2016 at 8:28 PM, Duy Nguyen <pclouds@gmail.com> wrote: >> On Tue, Mar 29, 2016 at 8:25 PM, <tboegi@web.de> wrote: >>> From: Torsten Bögershausen <tboegi@web.de> >>> >>> Factor out the retrival of the sha1 for a given path in >>> read_blob_data_from_index() into the function get_sha1_from_index(). >> >> Getting _sha1_ from index is one function call and a memory >> dereference or two. I think you mean get sha1 _file_ (or data) from >> index. Maybe put either word in the function name. > > Oops, shouldn't have trusted that function name in the @@ line. No > what you write in the commit message matches the patch. Sorry for the > noise. >
Thanks for the review. It feels that the naming isn't ideal, let's see if we can find a better function name.