[PATCH v2 3/7] Allow core.autocrlf=input and core.eol=crlf
- From
tboegi@web.de <tboegi@web.de>
- Date
- Apr 1, 2016, 16:08 UTC
- Message-ID
- <1459526906-19868-1-git-send-email-tboegi@web.de>
- In-Reply-To
- <xmqqegblor2l.fsf@gitster.mtv.corp.google.com>
From: Torsten Bögershausen <tboegi@web.de>
Commit 942e77 "Add "core.eol" config variable" adds a condition to the config parser: core.autocrlf=input is not allowed together with core.eol=crlf.
This may lead to unnecessary problems, when config files are parsed: A global config file sets core.autocrlf=input, the repo local config file sets is own configuration: core.eol=crlf
There is no need to prevent combinations in config.c, in any case core.autocrlf overrides core.eol. Allow all combinations of core.crlf and core.eol and document that core.autocrlf overrides core.eol.
Signed-off-by: Torsten Bögershausen <tboegi@web.de> --- Documentation/config.txt | 6 +++--- config.c | 4 ---- 2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt index 2cd6bdd..4a27ad4 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -337,9 +337,9 @@ core.quotePath:: core.eol:: Sets the line ending type to use in the working directory for - files that have the `text` property set. Alternatives are - 'lf', 'crlf' and 'native', which uses the platform's native - line ending. The default value is `native`. See + files that have the `text` property set when core.autocrlf is false. + Alternatives are 'lf', 'crlf' and 'native', which uses the platform's + native line ending. The default value is `native`. See linkgit:gitattributes[5] for more information on end-of-line conversion. diff --git a/config.c b/config.c index 9ba40bc..a6adc8b 100644 --- a/config.c +++ b/config.c @@ -803,8 +803,6 @@ static int git_default_core_config(const char *var, const char *value) if (!strcmp(var, "core.autocrlf")) { if (value && !strcasecmp(value, "input")) { - if (core_eol == EOL_CRLF) - return error("core.autocrlf=input conflicts with core.eol=crlf"); auto_crlf = AUTO_CRLF_INPUT; return 0; } @@ -830,8 +828,6 @@ static int git_default_core_config(const char *var, const char *value) core_eol = EOL_NATIVE; else core_eol = EOL_UNSET; - if (core_eol == EOL_CRLF && auto_crlf == AUTO_CRLF_INPUT) - return error("core.autocrlf=input conflicts with core.eol=crlf"); return 0; }
-- 2.8.0.rc2.2.g1a4d45a.dirty