From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 06 Jan 2025 16:04:54 GMT
Subject: Re: [PATCH 2/4] version: refactor get_uname_info()
Message-ID: <xmqqv7usylll.fsf@gitster.g>
In-Reply-To: <20250106103713.1452035-3-usmanakinyemi202@gmail.com>

Usman Akinyemi <usmanakinyemi202@gmail.com> writes:

> Some code from "builtin/bugreport.c" uses uname(2) to get system
> information.
>
> Let's refactor this code into a new get_uname_info() function, so
> that we can reuse it in a following commit.

This does two things: refactor and enhancement.  Shouldn't it do
pure refactoring in a single patch, with a follow-up patch that
extends it to allow the caller to hide the system details?