Re: [PATCH v2 1/2] [Outreachy] t3903-stash: test without configured user.name and user.email

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 16, 2018, 10:12 UTC
Message-ID: <xmqqsh01ib51.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <2f3612b8-5f26-adae-9a7f-05d16040938e@gmail.com>

Slavica Djukic <slavicadj.ip2018@gmail.com> writes:

Show 13 quoted lines

>>> +	git var GIT_COMMITTER_IDENT >actual &&
>>> +	test_cmp expected actual &&
>> I am not sure what you are testing with this step.  There is nothing
>> that changed environment variables or configuration since we ran
>> "git var" above.  Why does this test suspect that somebody in the
>> future may break the expectation that after running 'git add' and/or
>> 'git stash', our committer identity may have been changed, and how
>> would such a breakage happen?
> In previous re-roll, you suggested that test should be improved so
> that when
> reasonable identity is present, git stash executes under that
> identity, and not
> under the fallback one.

Yes, but for that you'd need to be checking the resulting commit object that represents the stash entry. It should be created under the substitute identity.

> Here I'm just making sure that after calling
> git stash,
> we still have same reasonable identity present.

I do not think such a test would detect it, even when "git stash" incorrectly used the fallback identity to create the stash entry.