Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 24, 2018, 07:39 UTC
Message-ID: <nycvar.QRO.7.76.6.1810240938310.4546@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqd0s0qcuv.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Wed, 24 Oct 2018, Junio C Hamano wrote:

Show 12 quoted lines

> Slavica <slavicadj.ip2018@gmail.com> writes:
> 
> > +test_expect_failure 'stash with HOME as non-existing directory' '
> > +    test_commit 1 &&
> > +    test_config user.useconfigonly true &&
> > +    test_config stash.usebuiltin true &&
> > +    (
> > +        HOME=$(pwd)/none &&
> > +        export HOME &&
> 
> What is the reason why this test needs to move HOME away from
> TRASH_DIRECTORY (set in t/test-lib.sh)?

This is to make sure that no user.name nor user.email is configured. That was my idea, hence I answer your question.

Ciao, Dscho

Show 13 quoted lines

> 
> > +        unset GIT_AUTHOR_NAME &&
> > +        unset GIT_AUTHOR_EMAIL &&
> > +        unset GIT_COMMITTER_NAME &&
> > +        unset GIT_COMMITTER_EMAIL &&
> > +        test_must_fail git config user.email &&
> > +        echo changed >1.t &&
> > +		git stash
> > +    )
> > +'
> > +
> >  test_done
>