Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 24, 2018, 09:58 UTC
Message-ID: <xmqqmur3mzsm.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.1810240938310.4546@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 19 quoted lines

> Hi Junio,
>
> On Wed, 24 Oct 2018, Junio C Hamano wrote:
>
>> Slavica <slavicadj.ip2018@gmail.com> writes:
>> 
>> > +test_expect_failure 'stash with HOME as non-existing directory' '
>> > +    test_commit 1 &&
>> > +    test_config user.useconfigonly true &&
>> > +    test_config stash.usebuiltin true &&
>> > +    (
>> > +        HOME=$(pwd)/none &&
>> > +        export HOME &&
>> 
>> What is the reason why this test needs to move HOME away from
>> TRASH_DIRECTORY (set in t/test-lib.sh)?
>
> This is to make sure that no user.name nor user.email is configured. That
> was my idea, hence I answer your question.

HOME is set to TRASH_DIRECTORY in t/test-lib.sh already, and we do so to avoid getting affected by the real $HOME/.gitconfig of the user who happens to be running the test suite.

With that in place for ages, this test still moves HOME away from TRASH_DIRECTORY, and that is totally unnecessary if it is only done to avoid getting affected by the real $HOME/.gitconfig of the user. After all, this single test is not unique in its need to avoid reading from user's $HOME/.gitconfig---so I expected there may be other reasons.

That is why I asked, and your response is not quite answering that question.