[PATCH v3 1/3] [Outreachy] t3903-stash: test without configured user name
- From
- Slavica Djukic <slavicadj.ip2018@gmail.com>
- Date
- Oct 25, 2018, 19:20 UTC
- Message-ID
- <9ea38cd8e98890b8264696dfd647c1f9e709ae9e.1540494231.git.slawica92@hotmail.com>
- In-Reply-To
- <cover.1540494231.git.slawica92@hotmail.com>
From: Slavica <slawica92@hotmail.com>
This is part of enhancement request that ask for 'git stash' to work even if 'user.name' and 'user.email' are not configured. Due to an implementation detail, git-stash undesirably requires 'user.name' and 'user.email' to be set, but shouldn't. The issue is discussed here: https://public-inbox.org/git/87o9debty4.fsf@evledraar.gmail.com/T/#u.
Signed-off-by: Slavica Djukic <slawica92@hotmail.com> --- t/t3903-stash.sh | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh index 9e06494ba0..ae2c905343 100755 --- a/t/t3903-stash.sh +++ b/t/t3903-stash.sh @@ -1156,4 +1156,18 @@ test_expect_success 'stash -- <subdir> works with binary files' ' test_path_is_file subdir/untracked ' +test_expect_failure 'stash works when user.name and user.email are not set' ' + test_commit 1 && + test_config user.useconfigonly true && + test_config stash.usebuiltin true && + sane_unset GIT_AUTHOR_NAME && + sane_unset GIT_AUTHOR_EMAIL && + sane_unset GIT_COMMITTER_NAME && + sane_unset GIT_COMMITTER_EMAIL && + test_unconfig user.email && + test_unconfig user.name && + echo changed >1.t && + git stash +' + test_done
-- 2.19.1.windows.1