Re: [PATCH v2 1/2] [Outreachy] t3903-stash: test without configured user.name and user.email

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 15, 2018, 12:37 UTC
Message-ID: <nycvar.QRO.7.76.6.1811151336330.41@tvgsbejvaqbjf.bet>
In-Reply-To: <20181114222524.2624-1-slawica92@hotmail.com>

Hi Slavica,

this looks very good to me. Just one grammar thing:

On Wed, 14 Nov 2018, Slavica Djukic wrote:

> Add test to document that stash fails if user.name and user.email
> are not configured.
> In the later commit, test will be updated to expect success.

In a later commit [...]

Otherwise, I would be totally fine with this version being merged.

Ciao, Johannes

Show 42 quoted lines

> 
> Signed-off-by: Slavica Djukic <slawica92@hotmail.com>
> ---
>  t/t3903-stash.sh | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
> index cd216655b..bab8bec67 100755
> --- a/t/t3903-stash.sh
> +++ b/t/t3903-stash.sh
> @@ -1096,4 +1096,27 @@ test_expect_success 'stash -- <subdir> works with binary files' '
>  	test_path_is_file subdir/untracked
>  '
>  
> +test_expect_failure 'stash works when user.name and user.email are not set' '
> +	git reset &&
> +	git var GIT_COMMITTER_IDENT >expected &&
> +	>1 &&
> +	git add 1 &&
> +	git stash &&
> +	git var GIT_COMMITTER_IDENT >actual &&
> +	test_cmp expected actual &&
> +	>2 &&
> +	git add 2 &&
> +	test_config user.useconfigonly true &&
> +	test_config stash.usebuiltin true &&
> +	(
> +		sane_unset GIT_AUTHOR_NAME &&
> +		sane_unset GIT_AUTHOR_EMAIL &&
> +		sane_unset GIT_COMMITTER_NAME &&
> +		sane_unset GIT_COMMITTER_EMAIL &&
> +		test_unconfig user.email &&
> +		test_unconfig user.name &&
> +		git stash
> +	)
> +'
> +
>  test_done
> -- 
> 2.19.1.1052.gd166e6afe
> 
>