Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

From: Slavica <slavicadj.ip2018@gmail.com>
Date: Oct 24, 2018, 13:56 UTC
Message-ID: <45cf8bf9-adfa-655e-0ded-fdb71707f7ad@gmail.com>
In-Reply-To: <CAP8UFD35aOb5weDcDVFth96e+H-as_Q9bLPuCpSDReKJERnM7Q@mail.gmail.com>

On 23-Oct-18 8:52 PM, Christian Couder wrote:

Show 11 quoted lines

> On Tue, Oct 23, 2018 at 6:35 PM Slavica <slavicadj.ip2018@gmail.com> wrote:
>> This is part of enhancement request that ask for `git stash` to work even if `user.name` is not configured.
>> The issue is discussed here: https://public-inbox.org/git/87o9debty4.fsf@evledraar.gmail.com/T/#u.
> We prefer commit messages that contain as much as possible all the
> information necessary to understand the patch without links to other
> places.
>
> It seems that only this email from you reached me. Did you send other
> emails for patches 2/3 and 3/3?
>
> [...]

Okay, I will change that. This is my first patch and I am still adapting.

Emails for patches 2/3 and 3/3 because aren't there because I am still preparing them.

(I didn't know if I had 3 patches in plan that they should be sent at almost the same time.)

Show 12 quoted lines

>
>> +    (
>> +        HOME=$(pwd)/none &&
>> +        export HOME &&
>> +        unset GIT_AUTHOR_NAME &&
>> +        unset GIT_AUTHOR_EMAIL &&
>> +        unset GIT_COMMITTER_NAME &&
>> +        unset GIT_COMMITTER_EMAIL &&
>> +        test_must_fail git config user.email &&
>> +        echo changed >1.t &&
>> +               git stash
> It seems that the above line is not indented like the previous ones.

I don't know what is the reason, in my IDE everything seems fine, but I'll fix it.

Show 5 quoted lines

>
>> +    )
>> +'
> Thanks for contributing,
> Christian.

You are welcome,

Slavica

>
>