Re: [PATCH 1/3] [Outreachy] t3903-stash: test without configured user name

From: Christian Couder <christian.couder@gmail.com>
Date: Oct 23, 2018, 18:52 UTC
Message-ID: <CAP8UFD35aOb5weDcDVFth96e+H-as_Q9bLPuCpSDReKJERnM7Q@mail.gmail.com>
In-Reply-To: <20181023162941.3840-1-slawica92@hotmail.com>

On Tue, Oct 23, 2018 at 6:35 PM Slavica <slavicadj.ip2018@gmail.com> wrote:

>
> This is part of enhancement request that ask for `git stash` to work even if `user.name` is not configured.
> The issue is discussed here: https://public-inbox.org/git/87o9debty4.fsf@evledraar.gmail.com/T/#u.

We prefer commit messages that contain as much as possible all the information necessary to understand the patch without links to other places.

It seems that only this email from you reached me. Did you send other emails for patches 2/3 and 3/3?

[...]

Show 10 quoted lines

> +    (
> +        HOME=$(pwd)/none &&
> +        export HOME &&
> +        unset GIT_AUTHOR_NAME &&
> +        unset GIT_AUTHOR_EMAIL &&
> +        unset GIT_COMMITTER_NAME &&
> +        unset GIT_COMMITTER_EMAIL &&
> +        test_must_fail git config user.email &&
> +        echo changed >1.t &&
> +               git stash

It seems that the above line is not indented like the previous ones.

> +    )
> +'

Thanks for contributing, Christian.