Re: [PATCH 1/3][Outreachy] t3903-stash: test without configured user.name and user.email

From: Christian Couder <christian.couder@gmail.com>
Date: Nov 1, 2018, 14:53 UTC
Message-ID: <CAP8UFD2qUotva_f+GmawHB3hr3W=rBy5V36yUWj7Majf2K61fQ@mail.gmail.com>
In-Reply-To: <20181101115834.19044-1-slawica92@hotmail.com>

On Thu, Nov 1, 2018 at 2:31 PM Slavica Djukic <slavicadj.ip2018@gmail.com> wrote:

>
> Add test to assert that stash fails if user.name and user.email

Nit: I am not sure that "assert" is the right word here.
test_expect_failure() is more for documenting an existing bug than for
really asserting a behavior (that users could rely upon). So I would
replace "assert" with "document" or maybe "document the bug".

> are not configured.
> In the final commit, test will be updated to expect success.

Other nit: maybe use "In a later commit" instead of "In the final commit" as you, or someone else, may add another commit in this patch series after the current final one.

> Signed-off-by: Slavica Djukic <slawica92@hotmail.com>

Thanks!