Re: [PATCH v2 1/3] [Outreachy] t3903-stash: test without configured user name

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Oct 24, 2018, 20:25 UTC
Message-ID: <CAPig+cRGn0Z7F7TpSwF=8cQJpN1LJkQb2VxHMDi6j6wsaqkORg@mail.gmail.com>
In-Reply-To: <a055296c2034a44f02c253ce3194018b21eb4e1f.1540410925.git.slawica92@hotmail.com>

On Wed, Oct 24, 2018 at 4:06 PM Slavica Djukic <slavicadj.ip2018@gmail.com> wrote:

> This is part of enhancement request that ask for 'git stash' to work
> even if 'user.name' and 'user.email' are not configured.
> Due to an implementation detail, git-stash undesirably requires
> 'user.name' and 'user.email' to be set, but shouldn't.

Thanks for re-rolling. This version looks better. One comment below...

Show 13 quoted lines

> Signed-off-by: Slavica Djukic <slawica92@hotmail.com>
> ---
> diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
> @@ -1156,4 +1156,17 @@ test_expect_success 'stash -- <subdir> works with binary files' '
> +test_expect_failure 'stash works when user.name and user.email are not set' '
> +    test_commit 1 &&
> +    test_config user.useconfigonly true &&
> +    test_config stash.usebuiltin true &&
> +    sane_unset GIT_AUTHOR_NAME &&
> +    sane_unset GIT_AUTHOR_EMAIL &&
> +    sane_unset GIT_COMMITTER_NAME &&
> +    sane_unset GIT_COMMITTER_EMAIL &&
> +    test_must_fail git config user.email &&

Instead of simply asserting that 'user.email' is not set here, you could instead proactively ensure that it is not set. That is, instead of the test_must_fail(), do this:

    test_unconfig user.email &&
    test_unconfig user.name &&

Show 8 quoted lines

> +    echo changed >1.t &&
> +    git stash
> +'
> +
>  test_done
> --
> 2.19.1.windows.1
>