Re: [PATCH 09/10] builtin/repack.c: extract loose object handling

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 21, 2021, 03:45 UTC
Message-ID: <xmqqk0s7c5rm.fsf@gitster.c.googlers.com>
In-Reply-To: <98c65017-8c22-a21f-0e86-a15d91bd7f70@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 11 quoted lines

> On 1/19/2021 6:24 PM, Taylor Blau wrote:
>> 'git repack -g' will have to learn about unreachable loose objects that
>
> This reference to the '-g' option is one patch too early. Perhaps
> say
>
>   An upcoming patch will introduce geometric repacking. This will
>   require removing unreachable loose objects in a separate path
>   from the existing checks.
>
> or similar?

Yeah, sounds like a trivially obvious improvement to me.

It does not matter to reviewers who are very well aware that the series is about adding "repack -g", but it may end up being confusing when somebody tries to see what commit the feature was added later when the help from the cover letter is not available.