Re: [PATCH v4 0/8] repack: support repacking into a geometric sequence

From: Taylor Blau <me@ttaylorr.com>
Date: Feb 23, 2021, 20:06 UTC
Message-ID: <YDVgPtkaTb9zNq0/@nand.local>
In-Reply-To: <1724378.IzK8VI2DXP@mfick-lnx>

On Tue, Feb 23, 2021 at 12:54:56PM -0700, Martin Fick wrote:

> Would it make sense to somehow detect all new packs since the last rollup and
> always include them in the rollup no matter what their size? That is one thing
> that my git-exproll script did.

I'm certainly not opposed, and this could certainly be done in an additive way (i.e., after this series). I think the current approach has nice properties, but I could also see "roll-up all packs that have mtimes after xyz timestamp" being useful.

It would even be possible to reuse a lot of the geometric repack machinery. Having a separate path to arrange packs by their mtimes and determine the "split" at pack whose mtime is nearest the provided one would do exactly what you want.

(As a side-note, reading the original threads about your git-exproll was quite humbling, since it turns out all of the problems I thought were hard had already been discussed eight years ago!)

Thanks, Taylor