Re: [PATCH 05/10] p5303: measure time to repack with keep
- From
Jeff King <peff@peff.net>
- Date
- Jan 29, 2021, 19:32 UTC
- Message-ID
- <YBRi4v/AeDD/Zc9X@coredump.intra.peff.net>
- In-Reply-To
- <xmqqft2ktnpj.fsf@gitster.c.googlers.com>
On Thu, Jan 28, 2021 at 07:40:40PM -0800, Junio C Hamano wrote:
Show 16 quoted lines
> > diff --git a/t/perf/p5303-many-packs.sh b/t/perf/p5303-many-packs.sh
> > index 277d22ec4b..85b077b72b 100755
> > --- a/t/perf/p5303-many-packs.sh
> > +++ b/t/perf/p5303-many-packs.sh
> > @@ -27,8 +27,11 @@ repack_into_n () {
>
> this construct:
>
> ... |
> sed -n '1~5p' |
> head -n "$1" |
> ...
>
> which is a GNUism. Peff often says that very small population
> actually run our perf suite, and this seems to corroborate the
> conjecture.Oops. Looks like I was the one who introduced that. Nobody seems to have complained, so I'm somewhat tempted to leave it. But it would not be too hard to replace with perl, I think.
-Peff