Re: [PATCH v2 0/8] repack: support repacking into a geometric sequence

From: Jeff King <peff@peff.net>
Date: Feb 17, 2021, 18:18 UTC
Message-ID: <YC1eD+m5acCpyEf2@coredump.intra.peff.net>
In-Reply-To: <YCxcyQcNO9LO2n9m@coredump.intra.peff.net>

On Tue, Feb 16, 2021 at 07:01:13PM -0500, Jeff King wrote:

Show 12 quoted lines

> On Wed, Feb 03, 2021 at 10:58:45PM -0500, Taylor Blau wrote:
> 
> > The details of the new approach can be found in the third patch, but the gist is
> > as follows:
> > [...]
> 
> I think this turned out very nice (and less complicated than I feared it
> might). I've read up through patch 5. I think the overall approach is
> good, but I had various small-to-medium comments.
> 
> I'll try to pick up reviewing the rest tomorrow, though it may make
> sense to resolve the earlier comments first.

OK, I finished reading the rest and left a few more comments. The short of it is that I really like the new direction, but I think there are enough small comments to merit a re-roll, which I hope would probably be the final.

-Peff