Re: [PATCH] p5303: avoid sed GNU-ism
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jan 29, 2021, 20:19 UTC
- Message-ID
- <CAPig+cTc3RGEu4anOmnYBBQxXgB0UL8Z_vJfnV=FoNTOFYEpTQ@mail.gmail.com>
- In-Reply-To
- <YBRqOI84MkU+HNzt@coredump.intra.peff.net>
On Fri, Jan 29, 2021 at 3:07 PM Jeff King <peff@peff.net> wrote:
Show 5 quoted lines
> Subject: [PATCH] p5303: avoid sed GNU-ism > > Using "1~5" isn't portable. Nobody seems to have noticed, since perhaps > people don't tend to run the perf suite on more exotic platforms. Still, > it's better to set a good example.
It's not just exotic platforms on which this can be a problem. BSD lineage `sed`, such as stock `sed` on macOS, doesn't understand this notation.
Thanks for eliminating this particular GNU-ism.