Re: [PATCH 05/10] p5303: measure time to repack with keep
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 29, 2021, 03:40 UTC
- Message-ID
- <xmqqft2ktnpj.fsf@gitster.c.googlers.com>
- In-Reply-To
- <b3b2574d4d9d10f226b52d81fe0e6bf1f761504e.1611098616.git.me@ttaylorr.com>
Taylor Blau <me@ttaylorr.com> writes:
> From: Jeff King <peff@peff.net>
Not a fault of this series at all, but before the precontext of the first hunk, there is
Show 5 quoted lines
> diff --git a/t/perf/p5303-many-packs.sh b/t/perf/p5303-many-packs.sh
> index 277d22ec4b..85b077b72b 100755
> --- a/t/perf/p5303-many-packs.sh
> +++ b/t/perf/p5303-many-packs.sh
> @@ -27,8 +27,11 @@ repack_into_n () {this construct:
... |
sed -n '1~5p' |
head -n "$1" |
...which is a GNUism. Peff often says that very small population actually run our perf suite, and this seems to corroborate the conjecture.
Show 29 quoted lines
> >pushes && > > # create base packfile > - head -n 1 pushes | > - git pack-objects --delta-base-offset --revs staging/pack && > + base_pack=$( > + head -n 1 pushes | > + git pack-objects --delta-base-offset --revs staging/pack > + ) && > + test_export base_pack && > > # and then incrementals between each pair of commits > last= && > @@ -87,6 +90,15 @@ do > --reflog --indexed-objects --delta-base-offset \ > --stdout </dev/null >/dev/null > ' > + > + test_perf "repack with keep ($nr_packs)" ' > + git pack-objects --keep-true-parents \ > + --honor-pack-keep --assume-kept-packs-closed \ > + --keep-pack=pack-$base_pack.pack \ > + --non-empty --all \ > + --reflog --indexed-objects --delta-base-offset \ > + --stdout </dev/null >/dev/null > + ' > done > > # Measure pack loading with 10,000 packs.