Re: [PATCH 09/10] builtin/repack.c: extract loose object handling
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Jan 20, 2021, 15:51 UTC
- Message-ID
- <ae13318c-f894-6c9a-414c-e7911abdef76@gmail.com>
- In-Reply-To
- <YAg/WU01bvfsMxgX@nand.local>
On 1/20/2021 9:34 AM, Taylor Blau wrote:
Show 22 quoted lines
> On Wed, Jan 20, 2021 at 08:59:48AM -0500, Derrick Stolee wrote: >> On 1/19/2021 6:24 PM, Taylor Blau wrote: >>> 'git repack -g' will have to learn about unreachable loose objects that >> >> This reference to the '-g' option is one patch too early. Perhaps >> say >> >> An upcoming patch will introduce geometric repacking. This will >> require removing unreachable loose objects in a separate path >> from the existing checks. >> >> or similar? > > Mmm. I had imagined that this would be read either in the context of > this series, or by someone in the future long after 'git repack -g' had > been introduced. > > I could see that it's confusing, though, and I do agree your wording > makes clearer that the option doesn't exist yet. > > I'm happy to send a replacement or reroll if you feel strongly, but in > either case I'll wait for a little more review first.
Definitely don't rush a re-roll for my nit-picks.
Thanks, -Stolee