Re: [PATCH 03/10] builtin/pack-objects.c: learn '--assume-kept-packs-closed'

From: Taylor Blau <me@ttaylorr.com>
Date: Jan 29, 2021, 20:01 UTC
Message-ID: <YBRprCmIX4IrHAi0@nand.local>
In-Reply-To: <YBRfvZh86Z8wAnxZ@coredump.intra.peff.net>

On Fri, Jan 29, 2021 at 02:19:25PM -0500, Jeff King wrote:

Show 8 quoted lines

> The overall goal here is being able to roll up loose objects and smaller
> packs without having to pay the cost of a full reachability traversal
> (which can take several minutes on large repositories). Another
> very-different direction there is to just enumerate those objects
> without respect to reachability, stick them in a pack, and then delete
> the originals. That does imply something like "repack -k", though, and
> interacts weirdly with letting unreachable objects age out via their
> mtimes (we'd constantly suck them back into fresh packs).

As I mentioned in an earlier response to Junio, this was the original approach that I took when implementing this, but ultimately decided against it because it means that we'll never let unreachable objects age out (as you note).

I wonder if we need our assumption that the union of kept packs is closed under reachability to be specified as an option. If the option is passed, then we stop the traversal as soon as we hit an object in the frozen packs. If not passed, then we do a full traversal but pass --honor-pack-keep to drop out objects in the frozen packs after the fact.

Thoughts?

Show 5 quoted lines

> I think it would want to be "the set of all .keep packs is closed". In a
> "roll all into one" scenario like above, there is only one .keep pack.
> But in a geometric progression, that single pack which constitutes your
> base set could be multiple packs (the last whole "git repack -ad", but
> then a sequence of roll-ups that came on top of it).

I don't think having a roll-up strategy of "all-except-one" simplifies things. Or, if it does, then I don't understand it. Isn't this the exact same thing as a geometric repack which decides to keep only one pack?

ISTM that you would be susceptible to the same problems in this case, too.

Thanks, Taylor