Re: [PATCH v4 02/10] t5526: stop asserting on stderr literally

From: Glen Choo <chooglen@google.com>
Date: Mar 5, 2022, 00:25 UTC
Message-ID: <kl6l1qzh454b.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <xmqqv8wtwa6u.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 9 quoted lines

> Jonathan Tan <jonathantanmy@google.com> writes:
>
>> The check_ names still aren't changed (as I suggested in [1]) but
>> perhaps it's fine to leave it. It doesn't seem to bother the other
>> reviewers, and changing it would slightly disrupt the review in that
>> there will be extra changes in the range-diff.
>
> At least, please do not count my not mentioning it as such a vote.
> I didn't mention it because I saw you did.

Oh! Sorry, I intended to do this - I missed this and another suggestion that you made re: test assertions [1]. Will incorporate this into the next round.

[1] 20220304234622.647776-1-jonathantanmy@google.com

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.