Re: [PATCH v4 01/10] t5526: introduce test helper to assert on fetches
- From
Glen Choo <chooglen@google.com>
- Date
- Mar 4, 2022, 22:11 UTC
- Message-ID
- <kl6l8rtp4bd2.fsf@chooglen-macbookpro.roam.corp.google.com>
- In-Reply-To
- <xmqqee3i5v4k.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 12 quoted lines
> Glen Choo <chooglen@google.com> writes:
>
>> +# Verifies that the expected repositories were fetched. This is done by
>> +# concatenating the files expect.err.[super|sub|deep] in the correct
>> +# order and comparing it to the actual stderr.
>> +#
>> +# If a repo should not be fetched in the test, its corresponding
>> +# expect.err file should be rm-ed.
>> +verify_fetch_result() {
>
> I think you updated 02/10 "check_sub () {" but this is leftover. If
> there aren't too many, I can fix them up locally. We'll see.Ugh, sorry about that.. I fixed this somewhere, but at some point I got my branches confused and must've missed this one.
Since you left comments on other patches (like [02/10] xmqq8rtq5uue.fsf@gitster.g), I'll just fix it on my end.