Re: [PATCH 2/8] submodule: store new submodule commits oid_array in a struct

From: Jonathan Tan <jonathantanmy@google.com>
Date: Feb 10, 2022, 19:00 UTC
Message-ID: <20220210190015.657085-1-jonathantanmy@google.com>
In-Reply-To: <20220210044152.78352-3-chooglen@google.com>

Glen Choo <chooglen@google.com> writes:

Show 8 quoted lines

> +/*
> + * Holds relevant information for a changed submodule. Used as the .util
> + * member of the changed submodule string_list_item.
> + */
> +struct changed_submodule_data {
> +	/* The submodule commits that have changed in the rev walk. */
> +	struct oid_array *new_commits;
> +};

Overall this change is straightforward and looks good, except that I think that the struct oid_array can be embedded directly instead of through a pointer.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.