Re: [PATCH v2 3/9] submodule: make static functions read submodules from commits

From: Glen Choo <chooglen@google.com>
Date: Feb 16, 2022, 06:59 UTC
Message-ID: <kl6lk0dv5map.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <20220215211848.1620058-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 8 quoted lines

> Glen Choo <chooglen@google.com> writes:
>> The changed function signatures follow repo_submodule_init()'s argument
>> order, i.e. "path" then "treeish_name". Where needed, reorder the
>> arguments of functions that already take "path" and "treeish_name" to be
>> consistent with this convention.
>
> This paragraph made me nervous, but looking at the diff, you didn't
> actually reorder any arguments. Probably best to delete this paragraph.

Oh you're right. I was sure that this paragraph used to be relevant, but I guess not. Thanks for the catch.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.