From: Glen Choo <chooglen@google.com>
Date: Sat, 05 Mar 2022 00:25:56 GMT
Subject: Re: [PATCH v4 02/10] t5526: stop asserting on stderr literally
Message-ID: <kl6l1qzh454b.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <xmqqv8wtwa6u.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Jonathan Tan <jonathantanmy@google.com> writes:
>
>> The check_ names still aren't changed (as I suggested in [1]) but
>> perhaps it's fine to leave it. It doesn't seem to bother the other
>> reviewers, and changing it would slightly disrupt the review in that
>> there will be extra changes in the range-diff.
>
> At least, please do not count my not mentioning it as such a vote.
> I didn't mention it because I saw you did.

Oh! Sorry, I intended to do this - I missed this and another suggestion
that you made re: test assertions [1]. Will incorporate this into the
next round.

[1] 20220304234622.647776-1-jonathantanmy@google.com