Re: [PATCH v3 02/10] t5526: stop asserting on stderr literally

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Feb 24, 2022, 18:13 UTC
Message-ID: <CAPig+cS3F8=dncj0rPeSWUibm2=4_L2VonCtPYUQ2V36OpUOPw@mail.gmail.com>
In-Reply-To: <kl6lpmnc44wu.fsf@chooglen-macbookpro.roam.corp.google.com>

On Thu, Feb 24, 2022 at 11:46 AM Glen Choo <chooglen@google.com> wrote:

Show 10 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> > On Thu, Feb 24 2022, Glen Choo wrote:
> >> +    sed -E 's/[0-9a-f]+\.\./OLD_HEAD\.\./' $ACTUAL_ERR >actual.err.cmp &&
> >
> > I think this is unportable per check-non-portable-shell.pl:
> >
> >         /\bsed\s+-[^efn]\s+/ and err 'sed option not portable (use only -n, -e, -f)';
>
> I used that because I wanted +, but I found what I needed from the sed
> manpage i.e. that + is equivalent to \{1,\}).

This isn't necessarily going to be portable either for older sed implementations. Most portable would be:

    [0-9a-f][0-9a-f]*

(Whether or not we need to worry about those older sed impmenetations is a different question...)