Re: [PATCH v3 07/10] submodule: extract get_fetch_task()
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- Feb 24, 2022, 23:26 UTC
- Message-ID
- <20220224232634.2881796-1-jonathantanmy@google.com>
- In-Reply-To
- <20220224100842.95827-8-chooglen@google.com>
Glen Choo <chooglen@google.com> writes:
Show 8 quoted lines
> @@ -1389,6 +1389,7 @@ struct fetch_task {
> struct repository *repo;
> const struct submodule *sub;
> unsigned free_sub : 1; /* Do we need to free the submodule? */
> + const char *default_argv;
>
> struct oid_array *commits; /* Ensure these commits are fetched */
> };I preferred the other way of passing default_argv in parallel, because it is only used for the interaction in between get_fetch_task() and get_next_submodule(), but I don't feel too strongly about this. In any case, up to and including this patch looks good.