Re: [PATCH 8/8] submodule: fix bug and remove add_submodule_odb()

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 10, 2022, 22:54 UTC
Message-ID: <xmqqpmnue3ig.fsf@gitster.g>
In-Reply-To: <20220210044152.78352-9-chooglen@google.com>

Glen Choo <chooglen@google.com> writes:

Show 7 quoted lines

> add_submodule_odb() is a hack - it adds a submodule's odb as an
> alternate, allowing the submodule's objects to be read via
> the_repository. Its last caller is submodule_has_commits(), which calls
> add_submodule_odb() to prepare for check_has_commit(). This used to be
> necessary because check_has_commit() used the_repository's odb, but this
> is longer true as of 13a2f620b2 (submodule: pass repo to
> check_has_commit(), 2021-10-08).

Yes! I wonder if we can do this much earlier in the series (or even an independent clean-up that the rest of the series depends on) and have it graduate earlier?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.