git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC PATCH v4 0/3] graph: add --graph-lane-limit option

From
Johannes Sixt <j6t@kdbg.org>
Date
Mar 25, 2026, 10:02 UTC
Message-ID
<fae2f8e3-029a-43c7-aa6e-45a452026853@kdbg.org>
In-Reply-To
<20260323215935.74486-1-pabloosabaterr@gmail.com>
Am 23.03.26 um 22:59 schrieb Pablo Sabater:
> Repositories that have many active branches at the same time produce
> wide graphs. A lane consists of two columns, the edge and the space
> padding, each branch takes a lane in the graph and there is no way
> to limit how many can be shown.

Generally, I like the goal of this patch series. However, the way in which it is presented and justified can be improved substantially, IMO.

It begins with the statement of what this patch series wants to achieve. It is "limit the width of the graph", isn't it? It is not "add --graph-lane-limit"; that is just a tool to achieve the goal.

To help reviewers, you should present an example chart in the cover letter that shows the before- and after-state (with and without the user of the new option).

As far as the separation into patches is concerned, I see a few problems. With the current separation is difficult to justify the patches. For example, the first patch adds prerequisites for a later patch, but it is unclear how these are used. The answer to the question "Why do we need this?" is simply "because the next patch uses them", but this is a very weak justification, because the next questions are "how are they used and why didn't you squash this into the next patch?"

Let me suggest a different separation.
1. The first patch limits the graph width with a hard-coded limit, say
15 lanes. It limits the graph *always*. Choose a limit that is large
enough to pass all tests.
2. The next patch adds --graph-lane-limit and its documentation. Let it
do its thing. Revert to the default limit value 0, i.e., unlimited.
3. Next, add additional eye-candy. I am alluding to the line that marks
where a graph lane was truncated.

(4. If more detailed document is warranted, e.g., an example chart, do this as a separate patch that can now show all bells and whistles that the earlier commits have implemented. Whether this makes sense as a separate step, or whether documentation grows with the earlier patches, is a judgement call.)

As far as commit messages are concerned, always, always provide an answer to "Why?" for every detail.

- Why do we want to limit the graph width?
- Why is the hard-coded limit 15? (because it lets tests pass and is
still a useful limit; we'll make it dynamic later.)
- Why do we always limit the graph width? (Because it makes this patch
simpler; we'll fix this later.)
- Why does 0 mean unlimited? (Consistency with --max-parents.)
- Why is the truncation marked with a fullstop "."? (...)

I'll also look over the patches, but I don't do C code, so I can provide only superficial comments, if any.

-- Hannes
Previous: PabloNext: Pablo
Message 25 of 48 in “graph: add --graph-max option to limit displayed columns”
  1. graph: add --graph-max option to limit displayed columnsPablo Sabater, Mar 16, 2026
  2. Karthik NayakMar 16, 2026
  3. PabloMar 16, 2026
  4. graph: add --max-columns option to limit displayed columnsPablo Sabater, Mar 17, 2026
  5. Junio C HamanoMar 18, 2026
  6. PabloMar 18, 2026
  7. Johannes SixtMar 19, 2026
  8. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 22, 2026
  9. 1/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 22, 2026
  10. 2/3 graph: truncate graph visual outputPablo Sabater, Mar 22, 2026
  11. 3/3 graph: add documentation and testing about --graph-lane-limitPablo Sabater, Mar 22, 2026
  12. Junio C HamanoMar 22, 2026
  13. PabloMar 23, 2026
  14. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 23, 2026
  15. 1/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 23, 2026
  16. SZEDER GáborMar 25, 2026
  17. Johannes SixtMar 25, 2026
  18. PabloMar 25, 2026
  19. 2/3 graph: truncate graph visual outputPablo Sabater, Mar 23, 2026
  20. Johannes SixtMar 25, 2026
  21. PabloMar 25, 2026
  22. 3/3 graph: add documentation and tests about --graph-lane-limitPablo Sabater, Mar 23, 2026
  23. Johannes SixtMar 25, 2026
  24. PabloMar 25, 2026
  25. Johannes SixtMar 25, 2026
  26. PabloMar 25, 2026
  27. Johannes SixtMar 25, 2026
  28. PabloMar 25, 2026
  29. 0/2 graph: add --graph-lane-limit optionPablo Sabater, Mar 25, 2026
  30. 1/2 graph: add --graph-lane-limit optionPablo Sabater, Mar 25, 2026
  31. Junio C HamanoMar 25, 2026
  32. PabloMar 27, 2026
  33. PabloMar 27, 2026
  34. Junio C HamanoMar 27, 2026
  35. 2/2 graph: add documentation and tests about --graph-lane-limitPablo Sabater, Mar 25, 2026
  36. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 28, 2026
  37. 1/3 graph: limit the graph width to a hard-coded maxPablo Sabater, Mar 28, 2026
  38. 2/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 28, 2026
  39. 3/3 graph: add truncation mark to capped lanesPablo Sabater, Mar 28, 2026
  40. Junio C HamanoMar 31, 2026
  41. Johannes SixtApr 1, 2026
  42. PabloApr 1, 2026
  43. Junio C HamanoApr 1, 2026
  44. PabloApr 2, 2026
  45. Junio C HamanoApr 2, 2026
  46. Tian YuchenApr 3, 2026
  47. PabloApr 3, 2026
  48. Junio C HamanoApr 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.