From: Johannes Sixt Date: Wed, 25 Mar 2026 10:02:56 GMT Subject: Re: [GSoC PATCH v4 0/3] graph: add --graph-lane-limit option Message-ID: In-Reply-To: <20260323215935.74486-1-pabloosabaterr@gmail.com> Am 23.03.26 um 22:59 schrieb Pablo Sabater: > Repositories that have many active branches at the same time produce > wide graphs. A lane consists of two columns, the edge and the space > padding, each branch takes a lane in the graph and there is no way > to limit how many can be shown. Generally, I like the goal of this patch series. However, the way in which it is presented and justified can be improved substantially, IMO. It begins with the statement of what this patch series wants to achieve. It is "limit the width of the graph", isn't it? It is not "add --graph-lane-limit"; that is just a tool to achieve the goal. To help reviewers, you should present an example chart in the cover letter that shows the before- and after-state (with and without the user of the new option). As far as the separation into patches is concerned, I see a few problems. With the current separation is difficult to justify the patches. For example, the first patch adds prerequisites for a later patch, but it is unclear how these are used. The answer to the question "Why do we need this?" is simply "because the next patch uses them", but this is a very weak justification, because the next questions are "how are they used and why didn't you squash this into the next patch?" Let me suggest a different separation. 1. The first patch limits the graph width with a hard-coded limit, say 15 lanes. It limits the graph *always*. Choose a limit that is large enough to pass all tests. 2. The next patch adds --graph-lane-limit and its documentation. Let it do its thing. Revert to the default limit value 0, i.e., unlimited. 3. Next, add additional eye-candy. I am alluding to the line that marks where a graph lane was truncated. (4. If more detailed document is warranted, e.g., an example chart, do this as a separate patch that can now show all bells and whistles that the earlier commits have implemented. Whether this makes sense as a separate step, or whether documentation grows with the earlier patches, is a judgement call.) As far as commit messages are concerned, always, always provide an answer to "Why?" for every detail. - Why do we want to limit the graph width? - Why is the hard-coded limit 15? (because it lets tests pass and is still a useful limit; we'll make it dynamic later.) - Why do we always limit the graph width? (Because it makes this patch simpler; we'll fix this later.) - Why does 0 mean unlimited? (Consistency with --max-parents.) - Why is the truncation marked with a fullstop "."? (...) I'll also look over the patches, but I don't do C code, so I can provide only superficial comments, if any. -- Hannes