git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC PATCH v6 0/3] graph: add --graph-lane-limit option

From
Tian Yuchen <a3205153416@gmail.com>
Date
Apr 3, 2026, 18:56 UTC
Message-ID
<dc134cdb-cdc3-4c54-a97e-993a26900d0d@gmail.com>
In-Reply-To
<xmqqikaawrpx.fsf@gitster.g>
On 4/2/26 00:49, Junio C Hamano wrote:
Show 54 quoted lines
> Pablo <pabloosabaterr@gmail.com> writes:
> 
>> While working on this I spent most of the time with graph.c and
>> I got to understand well how the rendering engine works. I think
>> I have an idea about how to tackle the column rearrangement
>> like gitk, which I believe is what you thought it was about at the
>> start (and the
>> TODO that's been on graph.c for 16 years c12172d2ea).
>>
>> FWIW, I'd like to send an RFC about the column rearrangement
>> because it would be better overall, no information is lost, you can
>> still limit the number of visible columns which would replace this
>> in most cases (only scenario I can think of where you still
>> want to keep the truncation would be if you want to keep the
>> branches going straight vertically).
>>
>> I'd like to hold this series and send the RFC with the idea for the
>> rearrangement. If it ends up not being viable I would come back
>> here and add a 4th patch to remove the extra padding lines
>> (merge and collapsing lines truncated) to make it more useful
>> making the graph more compact vertically as well.
> 
> Oh, I may have found a volunteer to fix one of my pet peeves ;-)
> 
> Imagine a history with multiple root commits and you are drawing the
> history near one of the roots.  Immediately fater pacing that root
> commit, the graphing engine seems to say "ah, the next display row
> immediately below this commit '*' is vacant because it does not have
> any parent.  We can draw a commit right there" and draws a commit
> that is unrelated to that root commit it just has drawn.
> 
> Which of course makes it impossible to tell that the commit on the
> earlier row is a root, if we draw a commit immediately below it.
> We'd want to leave that column/lane open for at least one row.
> 
> Instead of
> 
>      * a child of the root commit below
>      * one of the root commits
>      * an unrelated commit X
>      * the parent of X
>      * the other root commit that is a grandparent of X
> 
> we could probably draw
> 
>      * a child of the root commit below
>      * one of the root commits
>        * an unrelated commit X
>       /
>      * the parent of X
>      * the other root commit that is a grandparent of X
> 
> or you or somebody who stared at the graph engine much longer than I
> have may have even better ideas to draw such a history.

I have some reservations about this idea, although I know little about the graph engine. ;)

In terms of user conventions, in --graph, '/' and '\' represent branching and merging respectively. Here, however, the '/' used to break up between different root commits is merely a placeholder and has no specific meaning. I feel that this not only goes against user intuition but also creates visual confusion: (I just drew this off the cuff, but I reckon it should look something like this?)

Show 13 quoted lines
> * (main) commit 4
> | * (feature) commit 4
> | | * (doc1) commit
> | | * (doc1) root
> | |   * (main) commit 3
> | |  /| 
> | * | (feature) commit 3
> | |/
> | * (doc2) root
> |   * (main) commit 2 
> |  /
> * (feature) commit 2
> | * (main) commit 1

I don’t know about you, but I find this rather difficult to grasp. At the very least, I can’t tell at a glance where the actual merges and branches are. I don’t think a good solution should involve shifting left or right. Perhaps it would be better to use a special symbol in the root commit (such as the ■ symbol, which resembles a full stop? People would instinctively recognise it as a terminator):

|* (main) commit 2
| * (feature) commit 2
| ■ (doc1) ROOT COMMIT
* | (main) commit 1

(I wonder if there might be any character compatibility issues. Anyway, I like square characters. Square things are all rather cute.)

Regards, Yuchen
Previous: Junio C HamanoNext: Pablo
Message 46 of 48 in “graph: add --graph-max option to limit displayed columns”
  1. graph: add --graph-max option to limit displayed columnsPablo Sabater, Mar 16, 2026
  2. Karthik NayakMar 16, 2026
  3. PabloMar 16, 2026
  4. graph: add --max-columns option to limit displayed columnsPablo Sabater, Mar 17, 2026
  5. Junio C HamanoMar 18, 2026
  6. PabloMar 18, 2026
  7. Johannes SixtMar 19, 2026
  8. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 22, 2026
  9. 1/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 22, 2026
  10. 2/3 graph: truncate graph visual outputPablo Sabater, Mar 22, 2026
  11. 3/3 graph: add documentation and testing about --graph-lane-limitPablo Sabater, Mar 22, 2026
  12. Junio C HamanoMar 22, 2026
  13. PabloMar 23, 2026
  14. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 23, 2026
  15. 1/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 23, 2026
  16. SZEDER GáborMar 25, 2026
  17. Johannes SixtMar 25, 2026
  18. PabloMar 25, 2026
  19. 2/3 graph: truncate graph visual outputPablo Sabater, Mar 23, 2026
  20. Johannes SixtMar 25, 2026
  21. PabloMar 25, 2026
  22. 3/3 graph: add documentation and tests about --graph-lane-limitPablo Sabater, Mar 23, 2026
  23. Johannes SixtMar 25, 2026
  24. PabloMar 25, 2026
  25. Johannes SixtMar 25, 2026
  26. PabloMar 25, 2026
  27. Johannes SixtMar 25, 2026
  28. PabloMar 25, 2026
  29. 0/2 graph: add --graph-lane-limit optionPablo Sabater, Mar 25, 2026
  30. 1/2 graph: add --graph-lane-limit optionPablo Sabater, Mar 25, 2026
  31. Junio C HamanoMar 25, 2026
  32. PabloMar 27, 2026
  33. PabloMar 27, 2026
  34. Junio C HamanoMar 27, 2026
  35. 2/2 graph: add documentation and tests about --graph-lane-limitPablo Sabater, Mar 25, 2026
  36. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 28, 2026
  37. 1/3 graph: limit the graph width to a hard-coded maxPablo Sabater, Mar 28, 2026
  38. 2/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 28, 2026
  39. 3/3 graph: add truncation mark to capped lanesPablo Sabater, Mar 28, 2026
  40. Junio C HamanoMar 31, 2026
  41. Johannes SixtApr 1, 2026
  42. PabloApr 1, 2026
  43. Junio C HamanoApr 1, 2026
  44. PabloApr 2, 2026
  45. Junio C HamanoApr 2, 2026
  46. Tian YuchenApr 3, 2026
  47. PabloApr 3, 2026
  48. Junio C HamanoApr 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.