Re: [GSoC PATCH v6 0/3] graph: add --graph-lane-limit option
- From
Pablo <pabloosabaterr@gmail.com>
- Date
- Apr 3, 2026, 19:13 UTC
- Message-ID
- <CAN5EUNQbdoymmJcqzqzUy2aEKg-qUBqe_7bSmWwboJ4PoCfFJQ@mail.gmail.com>
- In-Reply-To
- <dc134cdb-cdc3-4c54-a97e-993a26900d0d@gmail.com>
El vie, 3 abr 2026 a las 20:56, Tian Yuchen (<a3205153416@gmail.com>) escribió:
Show 42 quoted lines
> > > I have some reservations about this idea, although I know little about > the graph engine. ;) > > In terms of user conventions, in --graph, '/' and '\' represent > branching and merging respectively. Here, however, the '/' used to break > up between different root commits is merely a placeholder and has no > specific meaning. I feel that this not only goes against user intuition > but also creates visual confusion: (I just drew this off the cuff, but I > reckon it should look something like this?) > > > * (main) commit 4 > > | * (feature) commit 4 > > | | * (doc1) commit > > | | * (doc1) root > > | | * (main) commit 3 > > | | /| > > | * | (feature) commit 3 > > | |/ > > | * (doc2) root > > | * (main) commit 2 > > | / > > * (feature) commit 2 > > | * (main) commit 1 > > I don’t know about you, but I find this rather difficult to grasp. At > the very least, I can’t tell at a glance where the actual merges and > branches are. I don’t think a good solution should involve shifting left > or right. Perhaps it would be better to use a special symbol in the root > commit (such as the ■ symbol, which resembles a full stop? People would > instinctively recognise it as a terminator): > > |* (main) commit 2 > | * (feature) commit 2 > | ■ (doc1) ROOT COMMIT > * | (main) commit 1 > > (I wonder if there might be any character compatibility issues. Anyway, > I like square characters. Square things are all rather cute.) > > Regards, Yuchen
Hi Yuchen, even tho we have diverged a little, this thread is for a new option to limit the graph horizontally, see the cover letter. It's currently being held, waiting for a RFC about column rearrangements. But I'm attempting the root commits issue before.
But what Junio mentioned is actually interesting and it's being discussed currently in a new thread, to avoid having two different topics here. at : https://lore.kernel.org/git/20260402211717.3604688-1-pabloosabaterr@gmail.com/
This seems to have been attempted multiple times and the idea to have a new symbol was thought of already. at: https://lore.kernel.org/git/191201d6eaa3$4b585fa0$e2091ee0$@pdinc.us/ from the same thread, but remarkable (part of the review from junio in the new thread): https://lore.kernel.org/git/xmqqwnwajbuj.fsf@gitster.c.googlers.com/
I already have some feedback and I'll send a v2 later today or maybe tomorrow, BUT testing and thoughts about it are very welcome, so feel free. Pablo.