Re: [GSoC PATCH v6 0/3] graph: add --graph-lane-limit option
- From
Pablo <pabloosabaterr@gmail.com>
- Date
- Apr 2, 2026, 05:53 UTC
- Message-ID
- <CAN5EUNRvsUgZPQhk4vj-QY8k+iCkTHQsgO8RJj1gNkYBDChsZg@mail.gmail.com>
- In-Reply-To
- <xmqqikaawrpx.fsf@gitster.g>
El mié, 1 abr 2026 a las 18:49, Junio C Hamano (<gitster@pobox.com>) escribió:
Show 32 quoted lines
> Oh, I may have found a volunteer to fix one of my pet peeves ;-) > > Imagine a history with multiple root commits and you are drawing the > history near one of the roots. Immediately fater pacing that root > commit, the graphing engine seems to say "ah, the next display row > immediately below this commit '*' is vacant because it does not have > any parent. We can draw a commit right there" and draws a commit > that is unrelated to that root commit it just has drawn. > > Which of course makes it impossible to tell that the commit on the > earlier row is a root, if we draw a commit immediately below it. > We'd want to leave that column/lane open for at least one row. > > Instead of > > * a child of the root commit below > * one of the root commits > * an unrelated commit X > * the parent of X > * the other root commit that is a grandparent of X > > we could probably draw > > * a child of the root commit below > * one of the root commits > * an unrelated commit X > / > * the parent of X > * the other root commit that is a grandparent of X > > or you or somebody who stared at the graph engine much longer than I > have may have even better ideas to draw such a history.
Ok, I like the idea and I think it should be relatively easy, something like if the last commit had no interesting parent to keep the padding like if it is still there for at least a row, then collapse the commit (unrelated X) back to the first column. So far I've got this:
* B | * A2 * A1 * A
Once I've got something more close to what you said I'll send a RFC PATCH on a clean thread and CC you.
About other ways to draw it, I actually like yours, other way I can think of is to make a hard separation row something like
> * a child of the root commit below > * one of the root commits
---
> * an unrelated commit X > * the parent of X > * the other root commit that is a grandparent of X
But I think yours is more minimal, with this it would be a new type of row to handle, etc. yours is to pretend that there is something, hide it and let it naturally collapse.