git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC PATCH WIP RFC v3 1/3] graph: add --graph-lane-limit option

From
Pablo <pabloosabaterr@gmail.com>
Date
Mar 23, 2026, 02:33 UTC
Message-ID
<CAN5EUNQ8rnBAezRLgATwotnw4EC--EAa3p+52nWb4KCtB7uySQ@mail.gmail.com>
In-Reply-To
<xmqqeclb7byr.fsf@gitster.g>
Junio C Hamano (<gitster@pobox.com>) writes:
Show 7 quoted lines
> If you have active branches, whether they are merged to some very
> small number of integration branches or they are left updating
> without getting merged for a long time, you'd end up getting very
> wide output from "log --all --graph"?  Or is this a problem only
> when these active branches are merged and having to show merge
> commits create the need for wider output?  I cannot quite see which
> from the above description.

The graph gets wide based on the branches active at the same time, each one occupies two columns, merges don't create new lanes. I'll improve the problem description.

Show 12 quoted lines
> The implementation detail that you happened to choose a C
> proprocessor macro instead of hardcoded constatnt to write the lower
> limit is not something readers of the log message needs to know.
> They can see that in the "log -p" output easily.
>
> What is more helpful for readers to know is what you mean by
> "graph-lane", what you are counting, and why you want its lower
> limit to 1 (instead of 0 or 2).  These reasoning behind the design
> is much more important to record to help future developers who want
> to fix bugs in this code or who want to extend the feature this code
> adds, without violating the underlying assumption and design goals
> of the original author (i.e., you).

Ok, I'll focus more on why, rather than how. the minimum is set to 1 to have at least 1 visible lane, even though it could accept 0 it's the same as not using this option, 0 it's treated as no limit and I found it better to not give the users the option to place it because no other option seems to behave like this, so I thought the best would be to force the input to be >= 1 to be valid. in v4 I'll make sure that this is clear for others.

Show 5 quoted lines
> This is "unsigned int"; don't we want the other places (like the
> on-stack local variable handle_revision_opt() uses to parse the
> value from the command line) and the parameter used in
> graph_needs_truncation() helper function all consistently use the
> same type?

I saw that other options like max_count, min/max_parents use int instead of unsigned int, so yes the most consistent would be to have it as int also, but it would make no sense to have -1 visible lanes. I thought it would be a good idea to keep it explicit that it can't be negative. this examples, max_count, etc were the closest examples I saw, but parse_count does return an int so i can't cast it to unsigned without checking if its neg that's why this

Show 5 quoted lines
> int max_lanes = parse_count(optarg);
> if (max_lanes < MINIMUM_GRAPH_COLUMNS)
>         die(_("minimum lanes is %d, cannot be set to %d"),
>                   MINIMUM_GRAPH_COLUMNS, max_lanes);
> revs->graph_max_lanes = max_lanes;

where it checks if it's < 1, now max_lanes has to be > 1 and it fits in an unsigned int. But i do understand to keep the consistency and the coding guidelines, i'll make it an int.

Thanks for the feedback!
Previous: Junio C HamanoNext: Pablo Sabater
Message 13 of 48 in “graph: add --graph-max option to limit displayed columns”
  1. graph: add --graph-max option to limit displayed columnsPablo Sabater, Mar 16, 2026
  2. Karthik NayakMar 16, 2026
  3. PabloMar 16, 2026
  4. graph: add --max-columns option to limit displayed columnsPablo Sabater, Mar 17, 2026
  5. Junio C HamanoMar 18, 2026
  6. PabloMar 18, 2026
  7. Johannes SixtMar 19, 2026
  8. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 22, 2026
  9. 1/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 22, 2026
  10. 2/3 graph: truncate graph visual outputPablo Sabater, Mar 22, 2026
  11. 3/3 graph: add documentation and testing about --graph-lane-limitPablo Sabater, Mar 22, 2026
  12. Junio C HamanoMar 22, 2026
  13. PabloMar 23, 2026
  14. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 23, 2026
  15. 1/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 23, 2026
  16. SZEDER GáborMar 25, 2026
  17. Johannes SixtMar 25, 2026
  18. PabloMar 25, 2026
  19. 2/3 graph: truncate graph visual outputPablo Sabater, Mar 23, 2026
  20. Johannes SixtMar 25, 2026
  21. PabloMar 25, 2026
  22. 3/3 graph: add documentation and tests about --graph-lane-limitPablo Sabater, Mar 23, 2026
  23. Johannes SixtMar 25, 2026
  24. PabloMar 25, 2026
  25. Johannes SixtMar 25, 2026
  26. PabloMar 25, 2026
  27. Johannes SixtMar 25, 2026
  28. PabloMar 25, 2026
  29. 0/2 graph: add --graph-lane-limit optionPablo Sabater, Mar 25, 2026
  30. 1/2 graph: add --graph-lane-limit optionPablo Sabater, Mar 25, 2026
  31. Junio C HamanoMar 25, 2026
  32. PabloMar 27, 2026
  33. PabloMar 27, 2026
  34. Junio C HamanoMar 27, 2026
  35. 2/2 graph: add documentation and tests about --graph-lane-limitPablo Sabater, Mar 25, 2026
  36. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 28, 2026
  37. 1/3 graph: limit the graph width to a hard-coded maxPablo Sabater, Mar 28, 2026
  38. 2/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 28, 2026
  39. 3/3 graph: add truncation mark to capped lanesPablo Sabater, Mar 28, 2026
  40. Junio C HamanoMar 31, 2026
  41. Johannes SixtApr 1, 2026
  42. PabloApr 1, 2026
  43. Junio C HamanoApr 1, 2026
  44. PabloApr 2, 2026
  45. Junio C HamanoApr 2, 2026
  46. Tian YuchenApr 3, 2026
  47. PabloApr 3, 2026
  48. Junio C HamanoApr 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.