git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC PATCH v5 1/2] graph: add --graph-lane-limit option

From
Pablo <pabloosabaterr@gmail.com>
Date
Mar 27, 2026, 14:22 UTC
Message-ID
<CAN5EUNSyBjpZHHAAd1YGVRjkLwzgGzpafhBJVTTcHJCLKNU2gQ@mail.gmail.com>
In-Reply-To
<xmqqh5q3sgnm.fsf@gitster.g>
Junio C Hamano (<gitster@pobox.com>) writes:
Show 46 quoted lines
>
> Pablo Sabater <pabloosabaterr@gmail.com> writes:
>
> > +static int graph_needs_truncation(struct git_graph *graph, int lane)
> > +{
> > +     int max = graph->revs->graph_max_lanes;
> > +     /*
> > +      * Ignore values <= 0, meaning no limit.
> > +      */
> > +     return max > 0 && lane >= max;
> > +}
>
> Make a mental note that this helper function works on number of
> lanes, not display columns (which is roughly twice the number of
> lanes).
>
> > @@ -696,6 +705,18 @@ static void graph_update_columns(struct git_graph *graph)
> >               }
> >       }
> >
> > +     /*
> > +      * If graph_max_lanes is set, cap the padding from the branches
> > +      */
> > +     if (graph->revs->graph_max_lanes > 0) {
> > +             /*
> > +              * width of "| " per lanes plus truncation mark "~ ".
> > +              */
> > +             int max_columns_width = graph->revs->graph_max_lanes * 2 + 2;
> > +             if (graph->width > max_columns_width)
> > +                     graph->width = max_columns_width;
> > +     }
> > +
> >       /*
> >        * Shrink mapping_size to be the minimum necessary
> >        */
> > @@ -846,6 +867,10 @@ static void graph_output_padding_line(struct git_graph *graph,
> >        * Output a padding row, that leaves all branch lines unchanged
> >        */
> >       for (i = 0; i < graph->num_new_columns; i++) {
> > +             if (graph_needs_truncation(graph, i)) {
> > +                     graph_line_addstr(line, "~ ");
> > +                     break;
> > +             }
>
> And that mental note helps to convince us this loop makes sense, as
> it increments 'i' one by one ;-)

Ok, I'll add the note to graph_needs_truncation() and any other places that might need to be more clear about if it handles columns or lanes.

Show 23 quoted lines
>
> > @@ -903,6 +928,9 @@ static void graph_output_pre_commit_line(struct git_graph *graph,
> >                       seen_this = 1;
> >                       graph_line_write_column(line, col, '|');
> >                       graph_line_addchars(line, ' ', graph->expansion_row);
> > +             } else if (seen_this && graph_needs_truncation(graph, i)) {
> > +                     graph_line_addstr(line, "~ ");
> > +                     break;
> >               } else if (seen_this && (graph->expansion_row == 0)) {
> >                       /*
> >                        * This is the first line of the pre-commit output.
> > @@ -994,6 +1022,12 @@ static void graph_draw_octopus_merge(struct git_graph *graph, struct graph_line
> >               col = &graph->new_columns[j];
> >
> >               graph_line_write_column(line, col, '-');
>
> And here, 'j' comes from graph->mapping[] array.  Does that count in
> display columns or lanes?
>
> > +             if (graph_needs_truncation(graph, j / 2 + i)) {
>
> This makes it look as if 'j' counts in columns and needs to be
> divided by 2 to make it comparable to lanes.

Actually, no, because there are other parts like graph_output_post_merge_line handling i and j like that and it is a more mechanical thing that logical I didn't double checked it, it should be something like commit_index + 1 + i similar to what j is, imma check to be sure and add another test for this to be sure because current ones pass this and that's why I thought it was ok in the first place.

Show 18 quoted lines
>
> > +                     graph_line_addstr(line, "~ ");
> > +                     break;
> > +             }
> > +
> >               graph_line_write_column(line, col, (i == dashed_parents - 1) ? '.' : '-');
> >       }
> >
>
> > +     if (graph->num_parents > 1) {
> > +             if (!graph_needs_truncation(graph, graph->commit_index)) {
> > +                     graph_update_state(graph, GRAPH_POST_MERGE);
> > +             } else {
> > +                     struct commit_list *first_parent = first_interesting_parent(graph);
> > +                     int first_parent_col = graph_find_new_column_by_commit(graph, first_parent->item);
>
> Are we sure that first_interesting_parent() will always give us a
> non-NULL pointer?
my bad, first_interestign_parent() can be a NULL, will add a check for that
Show 17 quoted lines
>
> Can we use a bit shorter identifier names to deal with these overly
> long lines?  The lifetime of these two variables is very short so they
> do not have to be so descriptive.
>
>                         struct commit *p = first_interesting_parent(graph)->item;
>                         int lane = graph_find_new_column_by_commit(graph, p);
>
> > +                     if (!graph_needs_truncation(graph, first_parent_col))
> > +                             graph_update_state(graph, GRAPH_POST_MERGE);
> > +                     else if (graph_is_mapping_correct(graph))
> > +                             graph_update_state(graph, GRAPH_PADDING);
> > +                     else
> > +                             graph_update_state(graph, GRAPH_COLLAPSING);
> > +             }
> > +     } else if (graph_is_mapping_correct(graph))
>
sure

Thanks for the feedback I'll start with the v6, Pablo.

Previous: Junio C HamanoNext: Pablo
Message 32 of 48 in “graph: add --graph-max option to limit displayed columns”
  1. graph: add --graph-max option to limit displayed columnsPablo Sabater, Mar 16, 2026
  2. Karthik NayakMar 16, 2026
  3. PabloMar 16, 2026
  4. graph: add --max-columns option to limit displayed columnsPablo Sabater, Mar 17, 2026
  5. Junio C HamanoMar 18, 2026
  6. PabloMar 18, 2026
  7. Johannes SixtMar 19, 2026
  8. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 22, 2026
  9. 1/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 22, 2026
  10. 2/3 graph: truncate graph visual outputPablo Sabater, Mar 22, 2026
  11. 3/3 graph: add documentation and testing about --graph-lane-limitPablo Sabater, Mar 22, 2026
  12. Junio C HamanoMar 22, 2026
  13. PabloMar 23, 2026
  14. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 23, 2026
  15. 1/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 23, 2026
  16. SZEDER GáborMar 25, 2026
  17. Johannes SixtMar 25, 2026
  18. PabloMar 25, 2026
  19. 2/3 graph: truncate graph visual outputPablo Sabater, Mar 23, 2026
  20. Johannes SixtMar 25, 2026
  21. PabloMar 25, 2026
  22. 3/3 graph: add documentation and tests about --graph-lane-limitPablo Sabater, Mar 23, 2026
  23. Johannes SixtMar 25, 2026
  24. PabloMar 25, 2026
  25. Johannes SixtMar 25, 2026
  26. PabloMar 25, 2026
  27. Johannes SixtMar 25, 2026
  28. PabloMar 25, 2026
  29. 0/2 graph: add --graph-lane-limit optionPablo Sabater, Mar 25, 2026
  30. 1/2 graph: add --graph-lane-limit optionPablo Sabater, Mar 25, 2026
  31. Junio C HamanoMar 25, 2026
  32. PabloMar 27, 2026
  33. PabloMar 27, 2026
  34. Junio C HamanoMar 27, 2026
  35. 2/2 graph: add documentation and tests about --graph-lane-limitPablo Sabater, Mar 25, 2026
  36. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 28, 2026
  37. 1/3 graph: limit the graph width to a hard-coded maxPablo Sabater, Mar 28, 2026
  38. 2/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 28, 2026
  39. 3/3 graph: add truncation mark to capped lanesPablo Sabater, Mar 28, 2026
  40. Junio C HamanoMar 31, 2026
  41. Johannes SixtApr 1, 2026
  42. PabloApr 1, 2026
  43. Junio C HamanoApr 1, 2026
  44. PabloApr 2, 2026
  45. Junio C HamanoApr 2, 2026
  46. Tian YuchenApr 3, 2026
  47. PabloApr 3, 2026
  48. Junio C HamanoApr 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.