git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC RFC PATCH] graph: add --graph-max option to limit displayed columns

From
Pablo <pabloosabaterr@gmail.com>
Date
Mar 16, 2026, 19:48 UTC
Message-ID
<CAN5EUNSzC9C3Sn3OP3df7Hur-S64khV7VVJoas138CfD4dcKpg@mail.gmail.com>
In-Reply-To
<CAOLa=ZSsC7zpfpRx8pShcqGEv_2_NMrKzJHCgTSaO=0Dg0xakg@mail.gmail.com>
Thanks for the feedback,
> Do you think '--graph-max' signifies that we're talking about the
> maximum columns to display?

Yeah, doesn't seem clear enough, but --graph-col-limit seems too verbose. What do you think about --graph-max-cols ? It's just one char less but I feel it is more readable.

> One question to ask is, is this even needed anymore and does it really
> make sense to add it?
> The TODO was added back in 2008, that's ~16 years ago and was not
> touched till now. So perhaps no one needs it? If so, maybe the smarter
> option is to simply remove the TODO?
> Or do you see a usecase where this is useful? If so, it would be nice to
> talk about that in the commit message.

I've run 'git log --graph --all' on the Git repo itself on 'next' and just scrolling a bit down up to March 5 there are already +35 branches, which isn't very readable.

It's been 16 years but I believe that is still a good thing to add, even if a lot of graph viewing happens with third parties, adding this makes Git a bit more self sufficient. This is even more useful in a case where the third party is not an option.

That said, if this still doesn't seem useful I would remove the TODO to avoid further confusion in the future.

> My preference would be not to have implicit behavior but also at the
> same time guide the user in the right path, so:
>      $ git log --graph-max=4
>      fatal: --graph-max used without --graph
Ok, will add this to v2.
> Trying it out:
> ...
> So we still keep the spaces, but only remove the column indicator
Padding needs to be adjusted to the columns truncated. Will add it to v2.
> Isn't this more of `graphs_needs_truncation()`?
Yes, I'll rename it in v2.
> Shouldn't we allow users to set 0? That combined with an unsigned int
> would:
> 1. remove the need for MINIMUM_GRAPH_COLUMNS
> 2. allow users to specify that they do not want a column limit
I think it's better not to let 0 be a good input, it's the same as not using it
making it redundant. Is set to 0 by default from the memset().
Other "max" options I've tried that allow 0, don't share the "no limit"
behaviour.
  git log --graph --all --max-parents=0
  git log --max-count=0
That's why I wouldn't let it be valid.
The unsigned int is better for clarity.
Show 5 quoted lines
> I think overall a little more explanation in the commit message makes it
> easier to understand the context and also helps reviewers!
>
> Shouldn't we also talk about the todo and the commit (c12172d2ea (Add
> history graph API, 2008-05-04)) in which it was added?
> The first sentence seems to talk about the option like it already
> exists, when the second para introduces it. It would be nice if the
> first para explained the problem we're trying to solve and why and the
> second para then dove into the solution space.

My bad, I'll improve the commit msg on v2 to be more clear about the problem, what it does and where it comes from.

> What does this mean? Validate how?

It validated user input to avoid them to set 0. In case of letting them set 0 (no limit) this would be removed.

I'll wait for the decision about whether this TODO from 2008 is worth doing before a v2.

Thanks, Pablo

Previous: Karthik NayakNext: Pablo Sabater
Message 3 of 48 in “graph: add --graph-max option to limit displayed columns”
  1. graph: add --graph-max option to limit displayed columnsPablo Sabater, Mar 16, 2026
  2. Karthik NayakMar 16, 2026
  3. PabloMar 16, 2026
  4. graph: add --max-columns option to limit displayed columnsPablo Sabater, Mar 17, 2026
  5. Junio C HamanoMar 18, 2026
  6. PabloMar 18, 2026
  7. Johannes SixtMar 19, 2026
  8. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 22, 2026
  9. 1/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 22, 2026
  10. 2/3 graph: truncate graph visual outputPablo Sabater, Mar 22, 2026
  11. 3/3 graph: add documentation and testing about --graph-lane-limitPablo Sabater, Mar 22, 2026
  12. Junio C HamanoMar 22, 2026
  13. PabloMar 23, 2026
  14. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 23, 2026
  15. 1/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 23, 2026
  16. SZEDER GáborMar 25, 2026
  17. Johannes SixtMar 25, 2026
  18. PabloMar 25, 2026
  19. 2/3 graph: truncate graph visual outputPablo Sabater, Mar 23, 2026
  20. Johannes SixtMar 25, 2026
  21. PabloMar 25, 2026
  22. 3/3 graph: add documentation and tests about --graph-lane-limitPablo Sabater, Mar 23, 2026
  23. Johannes SixtMar 25, 2026
  24. PabloMar 25, 2026
  25. Johannes SixtMar 25, 2026
  26. PabloMar 25, 2026
  27. Johannes SixtMar 25, 2026
  28. PabloMar 25, 2026
  29. 0/2 graph: add --graph-lane-limit optionPablo Sabater, Mar 25, 2026
  30. 1/2 graph: add --graph-lane-limit optionPablo Sabater, Mar 25, 2026
  31. Junio C HamanoMar 25, 2026
  32. PabloMar 27, 2026
  33. PabloMar 27, 2026
  34. Junio C HamanoMar 27, 2026
  35. 2/2 graph: add documentation and tests about --graph-lane-limitPablo Sabater, Mar 25, 2026
  36. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 28, 2026
  37. 1/3 graph: limit the graph width to a hard-coded maxPablo Sabater, Mar 28, 2026
  38. 2/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 28, 2026
  39. 3/3 graph: add truncation mark to capped lanesPablo Sabater, Mar 28, 2026
  40. Junio C HamanoMar 31, 2026
  41. Johannes SixtApr 1, 2026
  42. PabloApr 1, 2026
  43. Junio C HamanoApr 1, 2026
  44. PabloApr 2, 2026
  45. Junio C HamanoApr 2, 2026
  46. Tian YuchenApr 3, 2026
  47. PabloApr 3, 2026
  48. Junio C HamanoApr 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.