git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC PATCH v4 0/3] graph: add --graph-lane-limit option

From
Johannes Sixt <j6t@kdbg.org>
Date
Mar 25, 2026, 17:44 UTC
Message-ID
<251cbdd8-26ca-4569-9801-5eb278de7e0c@kdbg.org>
In-Reply-To
<CAN5EUNTXy+cFyHApdrhGKUqrvBGO0bb9X-=MaAWgp4DWOAkA-A@mail.gmail.com>
Am 25.03.26 um 13:28 schrieb Pablo:
Show 8 quoted lines
> Johannes Sixt (<j6t@kdbg.org>) writes:
>> Let me suggest a different separation.
> 
> I'll merge 1st and 2nd patch together into a single one, adding the option
> together with the actual logic that does it. This fixes what SZEDER said about
> the first patch alone breaking the build.
> 
> And the documentation + tests on a separate commit.

It is better to add documentation and tests in the same commit that add the feature, because both serve as a specification what the code is supposed to do. This way reviewers can decide whether the code does indeed work as designed. On top of that, when the code has to be inspected later, the commit that introduced the code shows immediately whether a certain behavior was intentional or not.

So, you would end up with a single patch.
But to make reviewing easier, I proposed a different split:
>> 1. The first patch limits the graph width with a hard-coded limit, say
>> 15 lanes. It limits the graph *always*. Choose a limit that is large
>> enough to pass all tests.
This change will touch the graphing engine, but almost nothing else.
>> 2. The next patch adds --graph-lane-limit and its documentation. Let it
>> do its thing. Revert to the default limit value 0, i.e., unlimited.

This change now introduces all the plumbing that passes the user's option through to the engine.

>> 3. Next, add additional eye-candy. I am alluding to the line that marks
>> where a graph lane was truncated.

If possible, this change provides final touches that can reasonably be left out from the first patch without compromising its basic functionality.

Show 5 quoted lines
>> (4. If more detailed document is warranted, e.g., an example chart, do
>> this as a separate patch that can now show all bells and whistles that
>> the earlier commits have implemented. Whether this makes sense as a
>> separate step, or whether documentation grows with the earlier patches,
>> is a judgement call.)

This could be a new paragraph in the manuals with example charts if doing so makes sense.

-- Hannes
Previous: PabloNext: Pablo
Message 27 of 48 in “graph: add --graph-max option to limit displayed columns”
  1. graph: add --graph-max option to limit displayed columnsPablo Sabater, Mar 16, 2026
  2. Karthik NayakMar 16, 2026
  3. PabloMar 16, 2026
  4. graph: add --max-columns option to limit displayed columnsPablo Sabater, Mar 17, 2026
  5. Junio C HamanoMar 18, 2026
  6. PabloMar 18, 2026
  7. Johannes SixtMar 19, 2026
  8. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 22, 2026
  9. 1/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 22, 2026
  10. 2/3 graph: truncate graph visual outputPablo Sabater, Mar 22, 2026
  11. 3/3 graph: add documentation and testing about --graph-lane-limitPablo Sabater, Mar 22, 2026
  12. Junio C HamanoMar 22, 2026
  13. PabloMar 23, 2026
  14. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 23, 2026
  15. 1/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 23, 2026
  16. SZEDER GáborMar 25, 2026
  17. Johannes SixtMar 25, 2026
  18. PabloMar 25, 2026
  19. 2/3 graph: truncate graph visual outputPablo Sabater, Mar 23, 2026
  20. Johannes SixtMar 25, 2026
  21. PabloMar 25, 2026
  22. 3/3 graph: add documentation and tests about --graph-lane-limitPablo Sabater, Mar 23, 2026
  23. Johannes SixtMar 25, 2026
  24. PabloMar 25, 2026
  25. Johannes SixtMar 25, 2026
  26. PabloMar 25, 2026
  27. Johannes SixtMar 25, 2026
  28. PabloMar 25, 2026
  29. 0/2 graph: add --graph-lane-limit optionPablo Sabater, Mar 25, 2026
  30. 1/2 graph: add --graph-lane-limit optionPablo Sabater, Mar 25, 2026
  31. Junio C HamanoMar 25, 2026
  32. PabloMar 27, 2026
  33. PabloMar 27, 2026
  34. Junio C HamanoMar 27, 2026
  35. 2/2 graph: add documentation and tests about --graph-lane-limitPablo Sabater, Mar 25, 2026
  36. 0/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 28, 2026
  37. 1/3 graph: limit the graph width to a hard-coded maxPablo Sabater, Mar 28, 2026
  38. 2/3 graph: add --graph-lane-limit optionPablo Sabater, Mar 28, 2026
  39. 3/3 graph: add truncation mark to capped lanesPablo Sabater, Mar 28, 2026
  40. Junio C HamanoMar 31, 2026
  41. Johannes SixtApr 1, 2026
  42. PabloApr 1, 2026
  43. Junio C HamanoApr 1, 2026
  44. PabloApr 2, 2026
  45. Junio C HamanoApr 2, 2026
  46. Tian YuchenApr 3, 2026
  47. PabloApr 3, 2026
  48. Junio C HamanoApr 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.