git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] ci: use system asciidoctor

From
Patrick Steinhardt <ps@pks.im>
Date
Sep 2, 2026, 09:59 UTC
Message-ID
<apfzihj-1YAhn5lT@pks.im>
In-Reply-To
<20260902090146.GA1791728@coredump.intra.peff.net>
On Wed, Sep 02, 2026 at 05:01:46AM -0400, Jeff King wrote:
Show 16 quoted lines
> On Wed, Sep 02, 2026 at 09:55:49AM +0200, Patrick Steinhardt wrote:
> 
> > One thing that we might have to worry about is compatibility with _old_
> > versions of asciidoctor. Now that we're using a more modern version of
> > it we might start relying on features that weren't available in older
> > versions, and we wouldn't notice anymore. So we kind of have the reverse
> > problem now.
> 
> Right, this is the "we could in theory check both" path I mentioned
> earlier.
> 
> v1.5.8 is sufficiently old that I don't think we need to care anymore.
> We can still take bug reports if somebody happens to use it and finds a
> problem. Checking other older versions isn't likely to be that
> interesting (the next version after 1.5.8 is 2.0.0, which had a higher
> than usual chance of breaking things).

Yeah, I agree. We can still reconsider if we ever hit a scenario where it caused problems after all.

Show 18 quoted lines
> > >  Documentation)
> > > -	sudo apt-get -q -y install asciidoc xmlto docbook-xsl-ns make ruby
> > > +	sudo apt-get -q -y install asciidoc xmlto docbook-xsl-ns make ruby \
> > > +		asciidoctor
> > >  
> > > -	sudo gem install --version 1.5.8 asciidoctor
> > >  	sudo gem install concurrent-ruby
> > 
> > Huh. I was wondering whether we can now stop installing Ruby altogether,
> > but we still install the "concurrent-ruby" Gem. But what even is that,
> > and what do we use it for?
> > 
> > It's originally been introduced via 974cdca345 (doc: introduce a
> > synopsis typesetting, 2024-09-24), but unfortunately the commit message
> > does not document why we have to install that Gem now. I couldn't find
> > any reasoning in the mailing list thread, either.
> 
> Er, yeah, see my cover letter. :)

D'oh, yeah. I somehow skipped reading the cover letter altogether, sorry.

Patrick
Previous: Jeff KingNext: Jeff King
Message 12 of 21 in “ci: fix missing Ruby dependency in "documentation" job”
  1. ci: fix missing Ruby dependency in "documentation" jobPatrick Steinhardt, Sep 1, 2026
  2. Toon ClaesSep 1, 2026
  3. Patrick SteinhardtSep 1, 2026
  4. Jeff KingSep 1, 2026
  5. Jeff KingSep 1, 2026
  6. Patrick SteinhardtSep 1, 2026
  7. 0/2 bump ci asciidoctor versionJeff King, Sep 2, 2026
  8. 1/2 ci: drop ALREADY_HAVE_ASCIIDOCTOR variableJeff King, Sep 2, 2026
  9. 2/2 ci: use system asciidoctorJeff King, Sep 2, 2026
  10. Patrick SteinhardtSep 2, 2026
  11. Jeff KingSep 2, 2026
  12. Patrick SteinhardtSep 2, 2026
  13. Jeff KingSep 5, 2026
  14. Todd ZullingerSep 5, 2026
  15. Jeff KingSep 11, 2026
  16. ci: use system asciidoctorTuomas Ahola, Sep 11, 2026
  17. Jeff KingSep 11, 2026
  18. Junio C HamanoSep 11, 2026
  19. Tuomas AholaSep 11, 2026
  20. Junio C HamanoSep 11, 2026
  21. Junio C HamanoSep 1, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.