Re: [PATCH] ci: fix missing Ruby dependency in "documentation" job

From: Jeff King <peff@peff.net>
Date: Sep 1, 2026, 08:51 UTC
Message-ID: <20260901085138.GA2974806@coredump.intra.peff.net>
In-Reply-To: <20260901084737.GA2973751@coredump.intra.peff.net>

On Tue, Sep 01, 2026 at 04:47:38AM -0400, Jeff King wrote:

Show 9 quoted lines

> Not directly related to your patch but... asciidoctor 1.5.8, really?
> That version is 8 years old. Looks like we set that version in
> 615a6c37e1 (ci: stick with Asciidoctor v1.5.8 for now, 2019-03-29)
> due to some issues with the then-new-ish v2.0.0.
> 
> But these days I'd guess everybody is using v2.0.x (which seems to work
> fine) for local builds. We probably ought to do the same in CI. If we
> have to catch issues in one, I'd rather it be the one people are likely
> to actually use.

Ah, indeed. It was fixed in f6461b82b9 (Documentation: fix build with Asciidoctor 2, 2019-09-15). The thread here:

  https://lore.kernel.org/git/20190915212621.GV11334@genre.crustytoothpaste.net

suggests that it could be removed, but was just waiting on a few more fixes for the v2 series. I guess nobody ever circled back around to it.

-Peff