Re: [PATCH] ci: fix missing Ruby dependency in "documentation" job
- From
Jeff King <peff@peff.net>
- Date
- Sep 1, 2026, 08:47 UTC
- Message-ID
- <20260901084737.GA2973751@coredump.intra.peff.net>
- In-Reply-To
- <20260901-b4-pks-ci-fix-documentation-job-v1-1-a8257ee2a9a4@pks.im>
On Tue, Sep 01, 2026 at 10:16:11AM +0200, Patrick Steinhardt wrote:
Show 6 quoted lines
> Our "documentation" job has recently stopped working with the following > error: > > + sudo gem install --version 1.5.8 asciidoctor > + gem install --version 1.5.8 asciidoctor > ./ci/install-dependencies.sh: 23: gem: not found
Not directly related to your patch but... asciidoctor 1.5.8, really? That version is 8 years old. Looks like we set that version in 615a6c37e1 (ci: stick with Asciidoctor v1.5.8 for now, 2019-03-29) due to some issues with the then-new-ish v2.0.0.
But these days I'd guess everybody is using v2.0.x (which seems to work fine) for local builds. We probably ought to do the same in CI. If we have to catch issues in one, I'd rather it be the one people are likely to actually use.
It's possible that we could benefit from building with both in order to support the older version. But given its age I doubt it's worth it. We can still take bug fixes if somebody finds a problem, but we don't necessarily need to spend cycles building every commit with 1.5.8.
-Peff