git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] ci: drop ALREADY_HAVE_ASCIIDOCTOR variable

From
Jeff King <peff@peff.net>
Date
Sep 2, 2026, 07:14 UTC
Message-ID
<20260902071409.GA641414@coredump.intra.peff.net>
In-Reply-To
<20260902071113.GA70165@coredump.intra.peff.net>

Our install-dependencies script avoids installing asciidoctor if the CI environment claims to have it already. But the only environment which made use of this was Azure Pipelines, which went away in 6081d3898f (ci: retire the Azure Pipelines definition, 2020-04-11). So this conditional was effectively doing nothing. Let's clean it up.

Signed-off-by: Jeff King <peff@peff.net>
---
 ci/install-dependencies.sh | 1 -
 1 file changed, 1 deletion(-)
diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
index 502e518077..2f61fbb07c 100755
--- a/ci/install-dependencies.sh
+++ b/ci/install-dependencies.sh
@@ -166,7 +166,6 @@ sparse)
 Documentation)
 	sudo apt-get -q -y install asciidoc xmlto docbook-xsl-ns make ruby
 
-	test -n "$ALREADY_HAVE_ASCIIDOCTOR" ||
 	sudo gem install --version 1.5.8 asciidoctor
 	sudo gem install concurrent-ruby
 	;;
-- 
2.55.0.1074.gcd259ea853
Previous: Jeff KingNext: Jeff King
Message 8 of 21 in “ci: fix missing Ruby dependency in "documentation" job”
  1. ci: fix missing Ruby dependency in "documentation" jobPatrick Steinhardt, Sep 1, 2026
  2. Toon ClaesSep 1, 2026
  3. Patrick SteinhardtSep 1, 2026
  4. Jeff KingSep 1, 2026
  5. Jeff KingSep 1, 2026
  6. Patrick SteinhardtSep 1, 2026
  7. 0/2 bump ci asciidoctor versionJeff King, Sep 2, 2026
  8. 1/2 ci: drop ALREADY_HAVE_ASCIIDOCTOR variableJeff King, Sep 2, 2026
  9. 2/2 ci: use system asciidoctorJeff King, Sep 2, 2026
  10. Patrick SteinhardtSep 2, 2026
  11. Jeff KingSep 2, 2026
  12. Patrick SteinhardtSep 2, 2026
  13. Jeff KingSep 5, 2026
  14. Todd ZullingerSep 5, 2026
  15. Jeff KingSep 11, 2026
  16. ci: use system asciidoctorTuomas Ahola, Sep 11, 2026
  17. Jeff KingSep 11, 2026
  18. Junio C HamanoSep 11, 2026
  19. Tuomas AholaSep 11, 2026
  20. Junio C HamanoSep 11, 2026
  21. Junio C HamanoSep 1, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.