Re: [PATCH 2/2] ci: use system asciidoctor
- From
Jeff King <peff@peff.net>
- Date
- Sep 2, 2026, 09:01 UTC
- Message-ID
- <20260902090146.GA1791728@coredump.intra.peff.net>
- In-Reply-To
- <apfWhYF6nmcFGKE3@pks.im>
On Wed, Sep 02, 2026 at 09:55:49AM +0200, Patrick Steinhardt wrote:
Show 5 quoted lines
> One thing that we might have to worry about is compatibility with _old_ > versions of asciidoctor. Now that we're using a more modern version of > it we might start relying on features that weren't available in older > versions, and we wouldn't notice anymore. So we kind of have the reverse > problem now.
Right, this is the "we could in theory check both" path I mentioned earlier.
v1.5.8 is sufficiently old that I don't think we need to care anymore. We can still take bug reports if somebody happens to use it and finds a problem. Checking other older versions isn't likely to be that interesting (the next version after 1.5.8 is 2.0.0, which had a higher than usual chance of breaking things).
Show 16 quoted lines
> > Documentation) > > - sudo apt-get -q -y install asciidoc xmlto docbook-xsl-ns make ruby > > + sudo apt-get -q -y install asciidoc xmlto docbook-xsl-ns make ruby \ > > + asciidoctor > > > > - sudo gem install --version 1.5.8 asciidoctor > > sudo gem install concurrent-ruby > > Huh. I was wondering whether we can now stop installing Ruby altogether, > but we still install the "concurrent-ruby" Gem. But what even is that, > and what do we use it for? > > It's originally been introduced via 974cdca345 (doc: introduce a > synopsis typesetting, 2024-09-24), but unfortunately the commit message > does not document why we have to install that Gem now. I couldn't find > any reasoning in the mailing list thread, either.
Er, yeah, see my cover letter. :)
-Peff