Re: [PATCH] ci: fix missing Ruby dependency in "documentation" job

From: Patrick Steinhardt <ps@pks.im>
Date: Sep 1, 2026, 10:41 UTC
Message-ID: <aparyEbGiiFZpiCZ@pks.im>
In-Reply-To: <20260901084737.GA2973751@coredump.intra.peff.net>

On Tue, Sep 01, 2026 at 04:47:37AM -0400, Jeff King wrote:

Show 18 quoted lines

> On Tue, Sep 01, 2026 at 10:16:11AM +0200, Patrick Steinhardt wrote:
> 
> > Our "documentation" job has recently stopped working with the following
> > error:
> > 
> >   + sudo gem install --version 1.5.8 asciidoctor
> >   + gem install --version 1.5.8 asciidoctor
> >   ./ci/install-dependencies.sh: 23: gem: not found
> 
> Not directly related to your patch but... asciidoctor 1.5.8, really?
> That version is 8 years old. Looks like we set that version in
> 615a6c37e1 (ci: stick with Asciidoctor v1.5.8 for now, 2019-03-29)
> due to some issues with the then-new-ish v2.0.0.
> 
> But these days I'd guess everybody is using v2.0.x (which seems to work
> fine) for local builds. We probably ought to do the same in CI. If we
> have to catch issues in one, I'd rather it be the one people are likely
> to actually use.

> It's possible that we could benefit from building with both in order to
> support the older version. But given its age I doubt it's worth it. We
> can still take bug fixes if somebody finds a problem, but we don't
> necessarily need to spend cycles building every commit with 1.5.8.

I was wondering about whether I should bump its version while at it. In fact, we could just install it from the Ubuntu sources nowadays, too. I ultimately decided to not do that though and just fix the failing CI pipeline for now, but I agree that it's something we might want to follow up on.

Patrick