Re: [PATCH] ci: fix missing Ruby dependency in "documentation" job
- From
Toon Claes <toon@iotcl.com>
- Date
- Sep 1, 2026, 08:24 UTC
- Message-ID
- <87pkyxwf9b.fsf@emacs.iotcl.com>
- In-Reply-To
- <20260901-b4-pks-ci-fix-documentation-job-v1-1-a8257ee2a9a4@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 9 quoted lines
> Our "documentation" job has recently stopped working with the following > error: > > + sudo gem install --version 1.5.8 asciidoctor > + gem install --version 1.5.8 asciidoctor > ./ci/install-dependencies.sh: 23: gem: not found > > The root cause of this is that we never explicitly install Ruby, and > consequently gem(1) isn't explicitly pulled inus, either. This used to
"inus"?
Show 5 quoted lines
> work alright because we transitively pulled in Ruby via asciidoc. But > due to an update it seems that we stopped pulling in the transitive > dependency, and consequently we don't have gem(1) available anymore. > > Fix this by explicitly installing Ruby.
Thanks for this fix, I was just looking at it as well, although I wasn't sure it started failing recently.
Show 24 quoted lines
> Signed-off-by: Patrick Steinhardt <ps@pks.im> > --- > Hi, > > I spotted the failure yesterday. You can see that this fixes the > pipeline at [1]. Thanks! > > Patrick > > [1]: https://gitlab.com/gitlab-org/git/-/merge_requests/660 > --- > ci/install-dependencies.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh > index 10c3530d1a..502e518077 100755 > --- a/ci/install-dependencies.sh > +++ b/ci/install-dependencies.sh > @@ -164,7 +164,7 @@ sparse) > libexpat-dev gettext zlib1g-dev sparse > ;; > Documentation) > - sudo apt-get -q -y install asciidoc xmlto docbook-xsl-ns make > + sudo apt-get -q -y install asciidoc xmlto docbook-xsl-ns make ruby
Good!
Show 7 quoted lines
> > test -n "$ALREADY_HAVE_ASCIIDOCTOR" || > sudo gem install --version 1.5.8 asciidoctor > > --- > base-commit: 1630431f326e15fcde608827b5ff38422528eb59 > change-id: 20260901-b4-pks-ci-fix-documentation-job-e971e10fbc94
Thanks!
-- Laters, Toon